Conversation
cthulhu-rider
force-pushed
the
bugfix/ec-expiration
branch
from
c450857 to
f27ca9f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3717 +/- ##
==========================================
+ Coverage 25.63% 25.66% +0.03%
==========================================
Files 657 657
Lines 42117 42135 +18
==========================================
+ Hits 10795 10814 +19
+ Misses 30342 30338 -4
- Partials 980 983 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
roman-khimov
reviewed
Dec 4, 2025
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
An update to counters is required as a part of migration as well. We've done it once, can do it again. We certainly have some expired big objects in mainnet, it's just that it's hard to notice anything in counters given the overall number/size of objects.
Contributor
Author
|
needs deeper examination |
cthulhu-rider
added
bug
Merged
Regression from 9a49cd0. Previously, shard miscounted removed parent objects as physical ones. This was reproduced in DevEnv: when split objects expired, metrics showed: ``` neofs_node_object_counter{shard="6pmbXUjzhKuvYnzrkUbeuP",type="phy"} -9 neofs_node_object_counter{shard="LpCtgJvdezqupmWtbM71rJ",type="phy"} -10 ``` Refs #3740. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/ec-expiration
branch
from
f27ca9f to
5d0aeea
Compare
cthulhu-rider
changed the title
Contributor
Author
|
updated changes to fix phy counter only. Left all the rest to #3740 |
carpawell
approved these changes
Jan 20, 2026
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
We need to update counters then, same as for 7->8 metabase version migration.
Contributor
Author
done, check pls |
cthulhu-rider
force-pushed
the
bugfix/ec-expiration
branch
from
ff263a9 to
448b612
Compare
cthulhu-rider
force-pushed
the
bugfix/ec-expiration
branch
from
448b612 to
2e0a045
Compare
Extend migration routine to forcefully re-calculate phy objects counter since it was managed incorrectly in previous versions. Refs #3740. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/ec-expiration
branch
from
2e0a045 to
59eb030
Compare
roman-khimov
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.